Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schedule-query): getUISchema function called in SchemaForm component #20256

Merged
merged 32 commits into from
Jul 5, 2022
Merged

fix(schedule-query): getUISchema function called in SchemaForm component #20256

merged 32 commits into from
Jul 5, 2022

Conversation

RahulRaj97
Copy link
Contributor

SUMMARY

Fixed getUISchema function call in ScheduleQueryButton Component

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Schedule UI - Before

Schedule UI - After

TESTING INSTRUCTIONS

Configure SCHEDULED_QUERIES in config.py and press the Schedule button in Sqllab

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: SCHEDULED_QUERIES
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Rahul Raj and others added 23 commits March 23, 2022 13:11
Merge pull request #2 from apache/master
e8e1e31 
Superset - Release and Improvements (23-03-2022)
Merge pull request #3 from apache/master
0720ee6 
Superset - Release and Improvements (28-03-2022)
Merge pull request #4 from apache/master
0d9405c 
Superset - Release and Improvements (04-04-2022)
Merge pull request #5 from apache/master
7e4af14 
Superset - Release and Improvements (07-04-2022)
Merge pull request #6 from apache/master
5938291 
Superset - Release and Improvements (11-04-2022)
Merge pull request #7 from apache/master
2f039d7 
Superset - Release and Improvements (19-04-2022)
Merge pull request #8 from apache/master
7f49f3a 
Superset - Release and Improvements (27-04-2022)
Merge pull request #9 from apache/master
230438e 
Superset - Release and Improvements (06-05-2022)
Merge pull request #10 from apache/master
c4debe6 
Superset - Release and Improvements (12-05-2022)
@RahulRaj97
Revert "Superset - Release and Improvements (12-05-2022)"
6d18661
Merge pull request #12 from careem/revert-10-master
7ffe7dc 
Revert "Superset - Release and Improvements (12-05-2022)"
Merge branch 'master' of https://github.com/apache/superset into apac…
00d8c87 
…he-new-master
merging conflic changes
894c619
Merge pull request #14 from careem/apache-new-master
fd1af9a 
Superset - Release and Improvements (Conflicts)
Revert "Revert "Superset - Release and Improvements (12-05-2022)""
9a3ee04 
This reverts commit 6d18661.
fixed breaking changes
bf8e88e
Merge pull request #16 from careem/apache-latest
595e9e6 
Revert "Revert "Superset - Release and Improvements (12-05-2022)""
sync with master
82e03b9
Merge pull request #17 from careem/fix-apache-master
6ce772b 
Sync with Master - Superset
Merge pull request #18 from apache/master
6c30d85 
Superset - Release and Improvements (23-05-2022)
fixed breaking flows
2edf94a
Merge pull request #19 from apache/master
ef17cb8 
feat: release and improvements (30-05-2022)
fixed getUISchema function call
00a6937
@RahulRaj97 RahulRaj97 changed the title [WIP] fix(schedule-query): getUISchema function called in SchemaForm component fix(schedule-query): getUISchema function called in SchemaForm component Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022 •
edited
Loading

Codecov Report

Merging #20256 (d60af23) into master (c8fe518) will increase coverage by 0.32%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #20256      +/-   ##
==========================================
+ Coverage   66.47%   66.79%   +0.32%     
==========================================
  Files        1727     1754      +27     
  Lines       64724    65562     +838     
  Branches     6822     6933     +111     
==========================================
+ Hits        43024    43794     +770     
- Misses      19969    20014      +45     
- Partials     1731     1754      +23
Flag Coverage Δ
hive 53.77% <100.00%> (+0.08%) ⬆️
mysql 82.36% <100.00%> (+0.20%) ⬆️
postgres 82.43% <100.00%> (+0.21%) ⬆️
presto 53.63% <100.00%> (+0.08%) ⬆️
python 82.86% <100.00%> (+0.22%) ⬆️
sqlite 82.22% <100.00%> (+0.26%) ⬆️
unit 50.64% <100.00%> (+1.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/SqlLab/components/ScheduleQueryButton/index.tsx 20.75% <ø> (ø)
superset/config.py 91.44% <100.00%> (+0.02%) ⬆️
...oard/components/gridComponents/new/NewMarkdown.jsx 0.00% <0.00%> (-100.00%) ⬇️
...s/legacy-plugin-chart-sunburst/src/controlPanel.ts 16.66% <0.00%> (-83.34%) ⬇️
...s/plugin-chart-echarts/src/BoxPlot/controlPanel.ts 16.66% <0.00%> (-83.34%) ⬇️
...gins/legacy-plugin-chart-chord/src/controlPanel.ts 25.00% <0.00%> (-75.00%) ⬇️
.../legacy-plugin-chart-world-map/src/controlPanel.ts 25.00% <0.00%> (-75.00%) ⬇️
...gins/legacy-plugin-chart-rose/src/controlPanel.tsx 50.00% <0.00%> (-50.00%) ⬇️
...ins/legacy-plugin-chart-sankey/src/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
...s/legacy-plugin-chart-calendar/src/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
... and 336 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8fe518...d60af23. Read the comment docs.

@villebro
Copy link
Member

villebro commented Jun 4, 2022 •
edited
Loading

@RahulRaj97 thanks for this fix. I started looking into this, and I noticed the following:

@pull-request-size pull-request-size bot added size/L and removed size/XS labels Jun 4, 2022
@RahulRaj97
Copy link
Contributor Author

RahulRaj97 commented Jun 4, 2022 •
edited
Loading

@villebro Thanks for reviewing the PR and clarifying the flags too. I was having the same issue while working on this and adding the SCHEDULED_QUERIES config inside FEATURE_FLAGS wasn't working for me so I tried adding it to the top-level config and it worked.

@hughhhh hughhhh merged commit 4137fe0 into apache:master Jul 5, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@RahulRaj97 @akshatsri
fix(schedule-query): getUISchema function called in SchemaForm compon…
c5f6a36 
…ent (apache#20256)

* Revert "Superset - Release and Improvements (12-05-2022)"

* merging conflic changes

* Revert "Revert "Superset - Release and Improvements (12-05-2022)""

This reverts commit 6d18661.

* fixed breaking changes

* sync with master

* fixed breaking flows

* fixed getUISchema function call

* added default placeholder and updated docs

* fixed format and comments

* changed flag to configuration

* fix: indentation of SCHEDULED_QUERIES dict

* fix: changed intendation for SCHEDULED_QUERIES

* fix: updated docs for SCHEDULED_QUERIES

* fix: replaced button to menu item for SCHEDULED_QUERIES

* fix: updated docs for SCHEDULED_QUERIES

* fix: trailing whitespace
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughhhh hughhhh hughhhh approved these changes

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RahulRaj97 @villebro @hughhhh @mistercrunch